Add support for BananaPi BPi-R2 #1135

abbradar · 2018-07-02T15:17:12Z

This is a minimal amount of patches to build working images for Banana Pi BPi-R2. Remaining major issues now are:

Boot from EMMC is not supported, only SD (see explanation in 03c35cec00db8ab51544346def64ea82111f29ca);
~~Internal Wi-Fi is broken (see below);~~
HNAT/HW QoS are not supported (see 7762c07).

Developers from BananaPi provide half-complete drivers for Mediatek connectivity chip which apparently are hacked Android drivers. Because of this:

Drivers need to be compiled into the kernel along with cfg80211 which conflicts with drivers for PCIe cards;
Their drivers confuse our network stack by creating network devices by themselves (just look at the procedure for initialization); we will likely need a separate backend for wifi to handle that.

Backported from the vendor tree with additional patches to build with GCC 7. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

It's useful on BPi-R2. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

This is a minimal amount of patches to get the router functional: * Hardcode kernel cmdline arguments in DTB for now (which means only SD image works, EMMC requires different partition settings); * Fix device memory size; * Fix LEDs settings; * Enable PCIe support; * Enable TRGMII on both GMACs which fixes LAN. Non-functional features: * Internal Wi-Fi (but you can use a PCIe card); * HW NAT/HW QoS; Untested features: * HDMI; * GPIO pins. All the changes apart from hardcoding cmdline are picked from the vendor's 4.9 tree. Vendor supplements needed bootargs via u-boot instead, which for some reason doesn't work. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

As mentioned in kernel patches only SD image is supported for now, however most needed code for EMMC images is added. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

General idea is copied from the vendor tree. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

Needed for MT6625L support on BananaPi BPi-R2.

Stand-alone WLAN drivers for Banana Pi BPi-R2.

Userspace part of WLAN drivers for BananaPi BPi-R2. Additionally implement wireless config initialization and start/stop/reload with quirks needed for the radio.

Certain wireless drivers (Mediatek) create interfaces by themselves and report "not supported" error when trying to create one from userspace. Handle this error code.

This is needed for some devices that handle non-zero values incorrectly, like BananaPi BPi-R2 onboard wifi chip.

Use phy device name as a last resort for identifying radios when reported MAC address is invalid. This is needed for Banana Pi BPi-R2 onboard wifi chip.

abbradar · 2018-07-11T15:09:36Z

I've managed to implement working internal Wi-Fi. Things are still very quirky but it appears to work with stock OpenWrt infrastructure (with some changes).

target/linux/mediatek/base-files/etc/inittab

blogic · 2018-08-06T11:51:05Z

target/linux/mediatek/image/make_bpi-r2_bundle_image.sh

+# This is free software, licensed under the GNU General Public License v2.
+# See /LICENSE for more information.
+#
+


this file should be turned into a real image building code template and not a shell script from within the image code.

How would one do that? Maybe there are examples in the code tree that I can use?

blogic · 2018-08-06T11:52:03Z

target/linux/mediatek/base-files/lib/upgrade/platform.sh

@@ -18,6 +18,15 @@ platform_do_upgrade() {
 		sync
 		umount /tmp/recovery
 		;;
+	bananapi,bpi-r2)


the change included inside the patch does not correlate with the patches subject/description

Sorry, I'm not sure what do you mean - I add support for sysupgrade here, and it says so in the patch subject. Should I rename it somehow?

target/linux/mediatek/patches-4.14/0228-arm-dts-mtk-bpi-r2-bootargs.patch

blogic · 2018-08-06T11:53:01Z

target/linux/mediatek/patches-4.14/0229-fix-memory-size-for-bpi-r2.patch

+ */
+ 	memory {
+-		reg = <0 0x80000000 0 0x20000000>;
+		reg = <0 0x80000000 0 0x80000000>;


patch the dts file directly

What do you mean?

@blogic Ping?

@abbradar: mt7623n-bananapi-bpi-r2.dts is upstream DTS file, if there is something wrong in it, please send upstream patch for that

at least for 4.19+ this is already fixed in upstream by this commit

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts?h=v4.19#n111

in 4.14 it is set to different value than these 2

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/tree/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts?h=linux-4.14.y#n104

blogic · 2018-08-06T11:53:06Z

target/linux/mediatek/patches-4.14/0229-update-gpio-leds-for-bpi-r2.patch

+ 		blue {
+ 			label = "bpi-r2:pio:blue";
+-			gpios = <&pio 241 GPIO_ACTIVE_HIGH>;
+			gpios = <&pio 240 GPIO_ACTIVE_LOW>;


patch the dts file directly

blogic · 2018-08-06T11:53:15Z

target/linux/mediatek/patches-4.14/0230-update-pcie-for-bpi-r2.patch

+ };
+
+&pcie {
+       pinctrl-names = "default";


patch the dts file directly

blogic · 2018-08-06T11:53:47Z

target/linux/mediatek/mt7623/config-4.14

@@ -58,6 +58,13 @@ CONFIG_BOUNCE=y
 CONFIG_CC_STACKPROTECTOR=y
 # CONFIG_CC_STACKPROTECTOR_NONE is not set
 CONFIG_CC_STACKPROTECTOR_REGULAR=y
+CONFIG_CFG80211=m


we dont use the kernel builtin cfg80211 layer

blogic · 2018-08-06T11:54:48Z

you are trying to add a driver with 1/4 million lines here cough :-)

blogic · 2018-08-06T11:58:53Z

@abbradar Hi, although i really appreciate your effort in improving the bananpiR2 support, I must admit that chances of these changes getting merged are near 0. we could merge the memory size cleanup and the console/commandline fix but the rest wont ever hit the master tree. the wifi driver alone is 1/4 million lines of code, requires the in-kernel cfg80211 layer, hostapd hacks. The quality of the rest of the patches is somewhat questionable as it was most likely copied 1:1 from the SDK.
sorry, if you want the minor fixes merged, open a dedicated PR for them.

abbradar

@blogic Many thanks for your review! I'll split and fix these patches, resubmitting some parts. I propose merging general improvements for the device, without internal WiFi support. Would this be okay?

abbradar · 2019-06-01T19:45:28Z

target/linux/mediatek/patches-4.14/0229-fix-memory-size-for-bpi-r2.patch

+ */
+ 	memory {
+-		reg = <0 0x80000000 0 0x20000000>;
+		reg = <0 0x80000000 0 0x80000000>;


What do you mean?

abbradar · 2019-06-01T19:53:48Z

@frank-w I'll try to rebase this atop master, will see what I can do.

abbradar · 2019-06-11T08:44:03Z

I've rebased and tested this; it works but for some reason jffs2 isn't mounted so there's no persistence. Unfortunately I had to RMA my CPU so I won't be able to look further for some time.

abbradar force-pushed the bpi-upstream branch 2 times, most recently from fc07402 to ca4c162 Compare July 2, 2018 15:37

mkresin added the target/mediatek pull request/issue for mediatek target label Jul 2, 2018

abbradar added 11 commits July 6, 2018 03:32

uboot-mtk-bpi-r2: add package

bfaa83d

Backported from the vendor tree with additional patches to build with GCC 7. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

mediatek: enable terminal on serial port

5b17a45

It's useful on BPi-R2. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

mediatek: build SD images for BPi-R2

7178919

As mentioned in kernel patches only SD image is supported for now, however most needed code for EMMC images is added. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

mediatek: add sysupgrade support for BPi-R2

c105067

General idea is copied from the vendor tree. Signed-off-by: Nikolay Amiantov <ab@fmap.me>

mediatek: add connectivity combo chip driver

b749e60

Needed for MT6625L support on BananaPi BPi-R2.

mt6625l-wlan-gen2: add package

e4f3a1b

Stand-alone WLAN drivers for Banana Pi BPi-R2.

wmt: add package

1d75333

Userspace part of WLAN drivers for BananaPi BPi-R2. Additionally implement wireless config initialization and start/stop/reload with quirks needed for the radio.

mac80211: handle 'not supported' error in interface add

ade3170

Certain wireless drivers (Mediatek) create interfaces by themselves and report "not supported" error when trying to create one from userspace. Handle this error code.

hostapd: expose bss_load_update_period option

fc4d703

This is needed for some devices that handle non-zero values incorrectly, like BananaPi BPi-R2 onboard wifi chip.

mac80211: fallback on phy devid

8f3500d

Use phy device name as a last resort for identifying radios when reported MAC address is invalid. This is needed for Banana Pi BPi-R2 onboard wifi chip.

abbradar force-pushed the bpi-upstream branch from ca4c162 to 8f3500d Compare July 11, 2018 15:07

blogic reviewed Aug 6, 2018

View reviewed changes

target/linux/mediatek/base-files/etc/inittab Show resolved Hide resolved

blogic reviewed Aug 6, 2018

View reviewed changes

target/linux/mediatek/patches-4.14/0228-arm-dts-mtk-bpi-r2-bootargs.patch Show resolved Hide resolved

blogic reviewed Aug 6, 2018

View reviewed changes

blogic closed this Aug 6, 2018

abbradar commented Jun 1, 2019

View reviewed changes

abbradar mentioned this pull request Sep 1, 2019

Add support for BananaPi BPi-R2, second take #2365

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for BananaPi BPi-R2 #1135

Add support for BananaPi BPi-R2 #1135

abbradar commented Jul 2, 2018 •

edited

abbradar commented Jul 11, 2018

blogic Aug 6, 2018

abbradar Sep 1, 2019

blogic Aug 6, 2018

abbradar Sep 1, 2019

blogic Aug 6, 2018

abbradar Jun 1, 2019

abbradar Sep 1, 2019

rmilecki Sep 1, 2019

frank-w Nov 1, 2019 •

edited

blogic Aug 6, 2018

blogic Aug 6, 2018

blogic Aug 6, 2018

blogic commented Aug 6, 2018

blogic commented Aug 6, 2018

abbradar left a comment

abbradar Jun 1, 2019

abbradar commented Jun 1, 2019

abbradar commented Jun 11, 2019

Add support for BananaPi BPi-R2 #1135

Add support for BananaPi BPi-R2 #1135

Conversation

abbradar commented Jul 2, 2018 • edited

abbradar commented Jul 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frank-w Nov 1, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blogic commented Aug 6, 2018

blogic commented Aug 6, 2018

abbradar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abbradar commented Jun 1, 2019

abbradar commented Jun 11, 2019

abbradar commented Jul 2, 2018 •

edited

frank-w Nov 1, 2019 •

edited